calculates deltas from unconfirmed transactions in bulk #3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to calculate the confirmed balance for a nasset we start with the unconfirmed balance and subtract the balance delta for each unconfirmed transaction. when we calculate confirmed balances for all assets we iterate over unconfirmed transactions once for each asset. defines 'getUnconfirmedDeltas' to sum the transaction balance deltas for all assets in one pass over unconfirmed transactions. defines 'getUnconfirmedDelta' to do the same for a particular asset. adds unit test removes outdated fixture
NullSoldier
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
to calculate the confirmed balance for a nasset we start with the unconfirmed balance and subtract the balance delta for each unconfirmed transaction.
when we calculate confirmed balances for all assets we iterate over unconfirmed transactions once for each asset.
defines 'getUnconfirmedDeltas' to sum the transaction balance deltas for all assets in one pass over unconfirmed transactions.
defines 'getUnconfirmedDelta' to do the same for a particular asset.
adds unit test
removes outdated fixture
Testing Plan
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.