Output error message when transaction amount is not greater than 0 #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irontankfish
changed the title
irontankfish
changed the title
hughy
reviewed
Feb 24, 2023
NullSoldier
approved these changes
Feb 26, 2023
|
I couldn't merge this in because it had lint failures that were failing the build. I took this code and did it for minimum, and other types of errors in this PR #3567 We'll still give you code credit but I'm going to close this PR. |
|
@irontankfish What graffiti do you want this credited to? |
|
@NullSoldier thanks for reaching out, and offering me credit. That is very nice of you guys. It should be under the same name: irontankfish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Output error message: "Please enter an amount greater than 0", when transaction amount is not greater than 0
Fixes: #3549
Testin
After burn:
After mint:
After send:
g Plan
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.