starts scanTransactions after account creation (#3659)

* starts scanTransactions after account creation

if a node is online and syncing at the time of account creation it's possible to
for an account head to be set to a block that is behind the wallet's
chainProcessor.

if the account's head is behind the chain processor then the wallet will not
scan any transactions for the account until the node is restarted.

runs scanTransactions after creating an account in the 'create' RPC so that a
newly created account will be synced with the chainProcessor if it is behind.
this matches the logic in the 'importAccount' RPC.

* mocks scanTransactions in beforeEach

ironfish/src/rpc/routes/wallet/create.test.slow.ts

@@ -13,6 +13,11 @@ import { RpcRequestError } from '../../clients/errors'
 describe('Route wallet/create', () => {
   jest.setTimeout(15000)
   const routeTest = createRouteTest()
+
+  beforeEach(() => {
+    jest.spyOn(routeTest.node.wallet, 'scanTransactions').mockReturnValue(Promise.resolve())
+  })
+
   it('should create an account', async () => {
     await routeTest.node.wallet.createAccount('existingAccount', true)
 
@@ -63,4 +68,24 @@ describe('Route wallet/create', () => {
       expect(e.code).toBe(ERROR_CODES.ACCOUNT_EXISTS)
     }
   })
+
+  it('should start scanning transactions for the new account', async () => {
+    const scanTransactions = jest
+      .spyOn(routeTest.node.wallet, 'scanTransactions')
+      .mockReturnValue(Promise.resolve())
+
+    await routeTest.node.wallet.createAccount('existingAccount', true)
+
+    const name = uuid()
+
+    const response = await routeTest.client.createAccount({ name })
+    expect(response.status).toBe(200)
+    expect(response.content).toMatchObject({
+      name: name,
+      publicAddress: expect.any(String),
+      isDefaultAccount: false,
+    })
+
+    expect(scanTransactions).toHaveBeenCalled()
+  })
 })

ironfish/src/rpc/routes/wallet/create.ts

@@ -42,6 +42,7 @@ router.register<typeof CreateAccountRequestSchema, CreateAccountResponse>(
     }
 
     const account = await node.wallet.createAccount(name)
+    void node.wallet.scanTransactions()
 
     let isDefaultAccount = false
     if (!node.wallet.hasDefaultAccount || request.data.default) {