Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for VisualVM 2.0 #20

Closed
jisedlac opened this issue Feb 21, 2020 · 5 comments
Closed

Update for VisualVM 2.0 #20

jisedlac opened this issue Feb 21, 2020 · 5 comments
Assignees

Comments

@jisedlac
Copy link

VisualVM 2.0 has been released and does not support plugins for VisualVM 1.x.

You may want to update the TDA plugin for VisualVM 2.0. Changing imports from com.sun.tools.visualvm.* to org.graalvm.visualvm.* and updating dependency versions should be enough.

I'm ready to provide any assistance if needed.

@irockel irockel self-assigned this Jun 19, 2020
irockel pushed a commit that referenced this issue Aug 19, 2020
@irockel
Copy link
Owner

irockel commented Aug 19, 2020

Updated tda integration to Visual VM 2.0, changed minimum jdk used inside TDA to 1.8. Will provide new nbms to you when maintenance release 2.4 is ready.

@irockel irockel closed this as completed Aug 19, 2020
@irockel
Copy link
Owner

irockel commented Sep 8, 2020

Issue for VisualVM Release: oracle/visualvm#224

@jisedlac
Copy link
Author

jisedlac commented Sep 9, 2020

We've tested the VisualVM modules and found two minor issues. Could you please address them before releasing on the VisualVM Plugin Center?

  1. Currently two modules would be visible on the Plugin Center: VisualVM-TDA-Module and VisualVM-Logfile-Module. Would be better if only the first module was visible to the user - it represents the whole plugin from the user's perspective
    tda_modules

  2. The TDA Options category should display at the end, after the standard VisualVM categories. Consider using TDA instead of the full name to keep the item small, but this is up to you - not a requirement.
    tda_options

@irockel
Copy link
Owner

irockel commented Sep 9, 2020

Adjusted plugin configuration as requested. The plugin files in the 2.4 release are updated with the changes.

@jisedlac
Copy link
Author

jisedlac commented Sep 9, 2020

Verified, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants