Humble backport and new fixes #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauropasse
force-pushed
the
mauro/irobot-humble-backport-fixes
branch
from
46a3f21
to
e8d9526
Compare
alsora
approved these changes
Aug 23, 2024
|
If this PR solves the Humble issue with the race condition in the ros actions, is there a plan for an upstream PR to be created to rclcpp for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
96e3adf: Backport ros2#2531 - Non IPC Action fixes
589885b: Fix feedback race - ros2#2451 (should open PR to upstream rclcpp)
46a3f21: Transient local: Fix corner case not seen before, consequence of the last fix #148
9435bee: Transient local: Fix applied to other publish signature
Tested test-actions / test-transient-local