Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Gradle: installBetterSqlite3 Task, update better-sqlite3 8.0.0 with SQLite3 3.40.0 (in nodejs) #86

Merged
merged 5 commits into from
Nov 22, 2022

Conversation

irgaly
Copy link
Owner

@irgaly irgaly commented Nov 8, 2022

Gradle でダウンロードした node を使ってビルドできるようにする。

@irgaly irgaly self-assigned this Nov 8, 2022
@irgaly
Copy link
Owner Author

irgaly commented Nov 13, 2022

WiseLibs/better-sqlite3#870
がマージされればもう少しビルドしやすくなる。

@irgaly
Copy link
Owner Author

irgaly commented Nov 22, 2022

WiseLibs/better-sqlite3#870 はマージされました。
better-sqlite3 の最新バージョンは 8.0.0

https://github.com/WiseLibs/better-sqlite3/releases/tag/v8.0.0

https://www.npmjs.com/package/better-sqlite3

@irgaly irgaly force-pushed the refactor/gradle_bettersqlite3 branch from f5d33ce to 80de8db Compare November 22, 2022 08:39
isIgnoreExitValue = true
extensions.configure<NodeJsRootExtension> {
// Choose any version you want to use from https://nodejs.org/en/download/releases/
nodeVersion = "19.1.0"
Copy link
Owner Author

@irgaly irgaly Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin Multiplatform で使われる node バージョンを指定できるようになった。

very smart 🎉

@irgaly irgaly changed the title Refactor Gradle: installBetterSqlite3 Task Refactor Gradle: installBetterSqlite3 Task, update better-sqlite3 8.0.0 with SQLite3 3.40.0 (in nodejs) Nov 22, 2022
@irgaly irgaly marked this pull request as ready for review November 22, 2022 09:10
@irgaly irgaly force-pushed the refactor/gradle_bettersqlite3 branch from d4e5f27 to 1f499ff Compare November 22, 2022 10:06
@irgaly irgaly merged commit c7c02c0 into main Nov 22, 2022
@irgaly irgaly deleted the refactor/gradle_bettersqlite3 branch November 22, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant