[water] allow empty operand list in wave.yield #693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't always have a value returned. Signed-off-by: Alex Zinenko <git@ozinenko.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the wave.yield operation to allow an empty operand list, enabling the operation to be used when no values need to be returned from an iteration.
Key Changes:
- Updated the assembly format for
YieldOpto make the type specification optional when no values are yielded - Added a test case demonstrating the usage of
wave.yieldwithout operands
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| water/include/water/Dialect/Wave/IR/WaveOps.td | Modified YieldOp assembly format to make type specification optional |
| water/test/Dialect/Wave/ops.mlir | Added test case @empty_yield to verify empty wave.yield functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ftynse
merged commit 8fa36fa
into
users/ftynse/harden-indexing-map-null
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't always have a value returned.