[Substrait] Make all RelOps Pure.
#828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
substrait-emit-pure
branch
from
3766176 to
16e333f
Compare
ingomueller-net
force-pushed
the
substrait-emit-pure
branch
from
16e333f to
9d4f4f2
Compare
jpienaar
approved these changes
May 29, 2024
ingomueller-net
force-pushed
the
substrait-emit-pure
branch
2 times, most recently
from
e6d635f to
0b0863c
Compare
This allows canonicalization to remove ops whose results aren't used. The commit also adapts one test to make sure that that is actually the case. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
force-pushed
the
substrait-emit-pure
branch
from
0b0863c to
ab42809
Compare
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
This allows canonicalization to remove ops whose results aren't used. The commit also adapts one test to make sure that that is actually the case. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
This allows canonicalization to remove ops whose results aren't used. The commit also adapts one test to make sure that that is actually the case. Signed-off-by: Ingo Müller <ingomueller@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on and, therefore, includes #830
and its dependencies.This allows canonicalization to remove ops whose results aren't used.
The commit also adapts one test to make sure that that is actually the
case.