[Substrait] Support root case in PlanRel message. #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2024
ingomueller-net
force-pushed
the
substrait-relroot-op
branch
from
789a0ae to
b8c2530
Compare
This essentially consist in adding optional field names to the `PlanRelOp`. Since verifying if those field names match the yielded type of the relation consists of the same logic as the one used in the verifier of the `NamedTableOp`, this commit also factors out that verification log. While touching that code, the commit also slightly extends the error messages emitted on verification failure.
ingomueller-net
force-pushed
the
substrait-relroot-op
branch
from
b8c2530 to
e0f8fde
Compare
jpienaar
approved these changes
May 15, 2024
ingomueller-net
commented
May 15, 2024
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…-sandbox#821) This essentially consist in adding optional field names to the `PlanRelOp`. Since verifying if those field names match the yielded type of the relation consists of the same logic as the one used in the verifier of the `NamedTableOp`, this commit also factors out that verification log. While touching that code, the commit also slightly extends the error messages emitted on verification failure. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…-sandbox#821) This essentially consist in adding optional field names to the `PlanRelOp`. Since verifying if those field names match the yielded type of the relation consists of the same logic as the one used in the verifier of the `NamedTableOp`, this commit also factors out that verification log. While touching that code, the commit also slightly extends the error messages emitted on verification failure. Signed-off-by: Ingo Müller <ingomueller@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on and, therefor, includes #820 and all of its dependencies.This essentially consist in adding optional field names to the
PlanRelOp. Since verifying if those field names match the yielded typeof the relation consists of the same logic as the one used in the
verifier of the
NamedTableOp, this commit also factors out thatverification log. While touching that code, the commit also slightly
extends the error messages emitted on verification failure.