Consume IREE as submodule by default. #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
iree-submodule
branch
3 times, most recently
from
6e733c6 to
33136a5
Compare
ingomueller-net
changed the title
nicolasvasilache
approved these changes
May 19, 2022
.gitmodules
Outdated
| @@ -0,0 +1,3 @@ | |||
| [submodule "third_party/iree"] | |||
| path = third_party/iree | |||
| url = https://github.com/nicolasvasilache/iree.git | |||
There was a problem hiding this comment.
you could take the real iree directly, I was just using my fork because I was maintaining the proper hash there.
ingomueller-net
force-pushed
the
iree-submodule
branch
from
33136a5 to
b170998
Compare
|
@webmiche: Note that the build process has changed with the landing of this PR. See the instructions in the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default build process such that IREE (and thus LLVM) is consumed as a git submodule instead of using a specific branch. This freezes the version of these dependencies such that unrelated updates of that branch do not affect them.