Skip to content

Split 'Desktop clients' into GUI/TUI and make tables less wide #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

progval
Copy link
Contributor

@progval progval commented Jun 2, 2021

So they fit on 13' screens without overflowing.

I also think it makes sense to split clients this way,
as they don't have the same audience.

Rendered view

@DanielOaks
Copy link
Member

Thanks for the PR!

Hmm, could we name them Desktop Clients and Terminal Clients, instead of Graphical Desktop and Console Desktop?

They may not have the same audience but I think it makes sense for them to sit in the same spot, just underneath Desktop Clients (so it'd be Desktop Clients, Terminal Clients, and then Web Clients).

I think the specs/ submodule accidentally got changed here as well, could you revert that to just being the one master's on? (currently 1b4050e)

@progval
Copy link
Contributor Author

progval commented Jun 2, 2021

Sure, done.

So they fit on 13' screens without overflowing.

I also think it makes sense to split clients this way,
as they don't have the same audience.
@DanielOaks
Copy link
Member

I'll leave this PR here for now. With how things get pushed down with the tables currently, it's hard to justify this for what we get in logical separation. I'm gonna open an issue for switching the columns+rows of the table and some other simplifications, and then we can re-evaluate this split when it won't cause as much hiding of other clients.

@progval progval closed this Nov 23, 2021
@progval progval deleted the split-clients branch November 23, 2021 18:16
@progval progval restored the split-clients branch November 23, 2021 18:31
@progval progval reopened this Nov 23, 2021
@progval
Copy link
Contributor Author

progval commented Nov 23, 2021

actually, this PR isn't relevant anymore

@progval progval closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants