Skip to content

clarify CHATHISTORY TARGETS semantics #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

clarify CHATHISTORY TARGETS semantics #565

wants to merge 1 commit into from

Conversation

slingamn
Copy link
Contributor

Clarify CHATHISTORY TARGETS semantics as follows:

The parameters have the same semantics as BETWEEN, except that they MUST be timestamps and not msgids, and they match against the latest message stored for the target (i.e. a target is not returned if its latest message is outside of the selection parameters, even if it has other messages inside them).

This appears to be a source of confusion, which is understandable because the previous text was ambiguous. However, the emendation here was always the intent (otherwise the selectors could not be used effectively for pagination).

@slingamn slingamn mentioned this pull request Jun 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@emersion emersion emersion approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slingamn @emersion