Skip to content

Conversation

@thegallagher
Copy link
Contributor

No description provided.

Copy link
Collaborator

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct, because it doesn't model the short-circuiting behavior. But the existing ?? handling doesn't do so either, so I guess this is fine as a starting point.

@nikic nikic merged commit f85725f into ircmaxell:master Jan 13, 2025
6 checks passed
@thegallagher
Copy link
Contributor Author

Thanks for the feedback. I assume the correct behaviour would be to expand null coalesce to JumpIf, as with LogicalAnd and LogicalOr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants