support trait use #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a few comments inline. The structure of the overall layout of classes is one thing i'd love feedback on, as the current implementation feels a bit too ad-hoc... |
ircmaxell
reviewed
Apr 12, 2022
lib/PHPCfg/Parser.php
Outdated
| foreach($node->adaptations as $adaptation) { | ||
| if($adaptation instanceof Stmt\TraitUseAdaptation\Alias) { | ||
| $adaptations[] = new Alias( | ||
| new Literal($adaptation->trait != null ? $adaptation->trait->toCodeString() : null), |
There was a problem hiding this comment.
Should the null be inside the Literal? Or should it be on the outside? As in $adaptation->trait !== null ? new Literal($adaptation->trait->toCodeString()) : null?
lib/PHPCfg/Parser.php
Outdated
| $adaptations[] = new Alias( | ||
| new Literal($adaptation->trait != null ? $adaptation->trait->toCodeString() : null), | ||
| new Literal($adaptation->method->name), | ||
| new Literal($adaptation->newName != null ? $adaptation->newName->name : null), |
There was a problem hiding this comment.
Same question here, should the null be on the outside?
lib/PHPCfg/TraitUseAdaptation.php
Outdated
| * @license MIT See LICENSE at the root of the project for more info | ||
| */ | ||
|
|
||
| namespace PHPCfg; |
There was a problem hiding this comment.
Shouldn't this be an Op class? Considering it will always have a line-number associated with it...
Perhaps structure like:
- Op\TraitUse
- Op\Statement\TraitUse
- Op\TraitUse\Adaptation
- Op\TraitUse\Alias
- Op\TraitUse\Precedence
Thoughts?
|
I modified it according to your comment, the current structure is
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,I add the feature to support trait use.