Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

fix media bugs with multiple peers to same user #8049

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

HexaField
Copy link
Contributor

Summary

PeerMediaChannelState made assumptions about and was determinded by an algorithm to select specific peers to be shown in the user media windows. PeerMediaChannelState should hold an entry for every peer, as logic is dependent upon it to handle consumers & producers.

Moving the assumption to the media window component itself cleans up the logic a lot, and fixes the issues.

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Copy link
Contributor

@barankyle barankyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested it locally, I saw that it won't display user bubbles until they have some sort of media transmitting. Is that what we want, or do we want to keep it where it shows up in non-immersive mode no matter what?

@HexaField
Copy link
Contributor Author

HexaField commented Jun 2, 2023

When I tested it locally, I saw that it won't display user bubbles until they have some sort of media transmitting. Is that what we want, or do we want to keep it where it shows up in non-immersive mode no matter what?

Was this for other users or just other peers? We want to show all users, but only peers if they have media, and if no peers have media, show the avatar thumbnail.

@HexaField HexaField marked this pull request as draft June 2, 2023 22:29
@HexaField HexaField marked this pull request as ready for review June 2, 2023 23:15
@HexaField HexaField merged commit 2c36be9 into dev Jun 2, 2023
@HexaField HexaField deleted the webrtc-peer-media-fixes branch June 2, 2023 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants