This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Moved ECR pruning to after all build services have succeeded. #10989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior behavior was to prune images for a service after that service had built successfully. This still had holes in the logic of which ones to remove, and sometimes several builds that had e.g. a failing client build would prune still-in-use api images, leading to the cluster being in a state where it had to run an older version of the code but the images with that code were gone. Now, prune_ecr_images is only run if every build has succeeded, which should prevent any pruning of images that need to still be used. Resolves IR-3455
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior behavior was to prune images for a service after that service had built successfully. This still had holes in the logic of which ones to remove, and sometimes several builds that had e.g. a failing client build would prune still-in-use api images, leading to the cluster being in a state where it had to run an older version of the code but the images with that code were gone.
Now, prune_ecr_images is only run if every build has succeeded, which should prevent any pruning of images that need to still be used.
Resolves IR-3455
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps