This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Component dependencies #10916
Merged
Component dependencies #10916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEstes
requested review from
dinomut1,
speigg,
CITIZENDOT,
AidanCaruso,
aditya-mitra and
SYBIOTE
as code owners
HexaField
previously requested changes
Aug 8, 2024
AidanCaruso
approved these changes
Aug 12, 2024
AidanCaruso
dismissed
HexaField’s stale review
Requested type change was addressed
MbfloydIR
added a commit
that referenced
this pull request
Aug 13, 2024
* dev: IR-3602-Changing-CSM-cascade-count-or-tonemapping-spams-errors (#10926) hotfix gizmo zeroed position on rigidbody entities (#10943) Add download progress bar and optimize util files (#10914) [IR-3547] studio: show unsaved changes dialog when switching between scenes (#10921) added tailwind class to break the line in the middle of words to prevent overflowing the alocated space (#10944) Updating the description of hemisphere lights to better explain what they do and why. (#10945) Left aligning the text in the "Add Component" and "Add Entity" menus (#10946) studio: open context menu on file menu right click (#10908) Fixed a bug with project PUTs without commit SHAs (#10942) IR-2873 Fix disabled state for select dropdown arrow (#10950) IR-3700: Added search by sso/email in user table (#10929) IR-3053: Add project-history service (#10736) Component dependencies (#10916) [IR-3324] studio: drag-n-drop folders (#10737) prevent scene from disappearing when double-clicking on a HierarchyTreeNode (#10932) fix tooltip css applied to all popups (#10938)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was getting a race condition on some scenes where the GLTF progress is never set to 100 because the models being checked in the useEffect are not reactive.
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps