-
Notifications
You must be signed in to change notification settings - Fork 6
ENH: modifications in prep for the documentation #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHANGED] this allows us to define different app types
[CHANGED] import whole composable module as this allows us to define different app types [CHANGED] make the piqtree_phylo a class to demo benefits in terms of the display of user help. [NEW] added substitution_mode.get_model() function which returns the enum given a string or enum. Modified Model to use this. This makes it easier for users to define the substitution models. A user should only ever have to import cogent3 to get everythjing they need from piqtree2.
[CHANGED] import whole composable module as this allows us to define different app types [CHANGED] make the piqtree_phylo a class to demo benefits in terms of the display of user help. [NEW] added substitution_mode.get_model() function which returns the enum given a string or enum. Modified Model to use this. This makes it easier for users to define the substitution models. A user should only ever have to import cogent3 to get everythjing they need from piqtree2.
[CHANGED] import whole composable module as this allows us to define different app types [CHANGED] make the piqtree_phylo a class to demo benefits in terms of the display of user help. [NEW] added substitution_mode.get_model() function which returns the enum given a string or enum. Modified Model to use this. This makes it easier for users to define the substitution models. A user should only ever have to import cogent3 to get everythjing they need from piqtree2.
[CHANGED] import whole composable module as this allows us to define different app types [CHANGED] make the piqtree_phylo a class to demo benefits in terms of the display of user help. [NEW] added substitution_mode.get_model() function which returns the enum given a string or enum. Modified Model to use this. This makes it easier for users to define the substitution models. A user should only ever have to import cogent3 to get everythjing they need from piqtree2.
[NEW] this provides access to the available_... functions [CHANGED] Added titles to all the tables that get returned
rmcar17
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, I think we just need to think about how to support things like rate heterogeneity etc. properly with the apps
[CHANGED] for now, we will direct users to web-based documentation
…re correct format)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.