Skip to content

ENH: add piqtree_nj as a cogent3 quick_tree hook #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

GavinHuttley
Copy link
Member

No description provided.

[CHANGED] The tree constructed by the piqtree_nj app
    is modified. The root node.params dict gets
    "provenance": "piqtree" entry. This is checked by
    the test for the new hook usage.

[NEW] the dev version of cogent3 provides a hook spec for
    quick_tree. We test this is working by using
    the new_type Alifgnment.quick_tree() method.
    Requires a cogent3 release > 2025.3
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13890359476

Details

  • 19 of 21 (90.48%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 98.731%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/test_app/test_app.py 13 15 86.67%
Totals Coverage Status
Change from base Build 13849617013: -0.2%
Covered Lines: 1167
Relevant Lines: 1182

💛 - Coveralls

@GavinHuttley GavinHuttley requested a review from rmcar17 March 17, 2025 03:34
@rmcar17 rmcar17 merged commit 895b831 into iqtree:main Mar 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants