bug fix: SplitDelegateClassloader inject is not compatible with Tinker #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tinker的从1.9.14.9版本开始,还会替换掉mBase中的mClassLoader。
com.iqiyi.android.qigsaw.core.splitload.SplitDelegateClassloader#inject的hook不彻底,只替换了mBase中的mPackageInfo里的mClassLoader,没有把mBase的mClassLoader也替换掉。
Tencent/tinker@b658362
Tinker hook的具体方法:
而当我们使用getApplicationContext().getClassLoader()获取ClassLoader,实际上是调用了Application中的mBase.getClassLoader()。而这个mBase是frameworks/base/core/java/android/app/ContextImpl.java,里面的getClassLoader实现:
因为mClassLoader被tinker注入了新的ClassLoader,所以会优先返回,而Qigsaw注入在mPackageInfo的ClassLoader,是无法被调用的。