Make NoDefaultSpecified an alias for Undefined#40
Merged
minrk merged 1 commit intoipython:masterfrom Jun 18, 2015
Merged
Conversation
Looks like the null values have been breeding
minrk
added a commit
that referenced
this pull request
Jun 18, 2015
Make NoDefaultSpecified an alias for Undefined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the null values have been breeding.
Everything I've tested seems to work fine with this change, and I can't find anywhere else in our code that we refer to
NoDefaultSpecifiedexplicitly.We do need to keep one special sentinel, because some traits can have a default value of
None, which is distinct from not having a default value.