Merged
Conversation
Member
Author
|
(I will add a test if you are fine with this.) |
5172f1c to
9b68f37
Compare
Member
|
I think it makes sense. I would do the same on Integer, though. |
Member
Author
|
Added a bounded Int. In Python 3.0, |
traitlets/traitlets.py
Outdated
Member
|
The error messages should also include the value that it was trying to set, I think, by analogy with the type mismatch error messages: "The '%s' trait of %s instance must be %s, but a value of %s was specified." |
Member
Author
|
@takluyver as per you suggestions. |
traitlets/traitlets.py
Outdated
Member
There was a problem hiding this comment.
repr_type() will return something like 200 <class 'int'>. Given that at this point it must be the correct type, we can just show its repr with %r in the format string.
Member
|
👍 |
Member
Author
|
green button? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@minrk This allows defining a
minandmaxattribute to aFloattrait type.