Allow adding multiple traits at once#27
Merged
minrk merged 1 commit intoipython:masterfrom Jun 5, 2015
Merged
Conversation
SylvainCorlay
force-pushed
the
add_traits
branch
2 times, most recently
from
4050fb9 to
e0a8821
Compare
traitlets/traitlets.py
Outdated
Member
There was a problem hiding this comment.
You need to iterate over traits.values() here.
Member
|
Other than a missing iteration now that it's a container instead of a single trait, this makes sense to me. |
minrk
added a commit
that referenced
this pull request
Jun 5, 2015
Allow adding multiple traits at once
Member
Author
|
Thanks, |
This was referenced Jun 5, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @sccolbert, allow adding multiple traits at once. This avoids creating too many new types when adding multiple decorators, since every call to add_trait was creating a new one.