Skip to content

Omit missing directories from MANIFEST.in#10

Merged
minrk merged 1 commit intoipython:masterfrom
neirbowj:clean_manifest
Feb 16, 2017
Merged

Omit missing directories from MANIFEST.in#10
minrk merged 1 commit intoipython:masterfrom
neirbowj:clean_manifest

Conversation

@neirbowj
Copy link
Contributor

Some combinations of python and setuptools (e.g. 3.4.6 + 32.1.0) trace with FileNotFoundError on a graft with a missing directory.

@Carreau
Copy link
Member

Carreau commented Feb 15, 2017

e.g. 3.4.6 + 32.1.0

😞
@minrk , @takluyver do we merge and released a 0.2 ? We've got 1 other patch that have been merged in last year.

@minrk
Copy link
Member

minrk commented Feb 16, 2017

@neirbowj how exactly did you run into this? I've tested with 3.4.5 + 32.1.0 and there are no errors.

MANIFEST.in should only affect sdists, so this doesn't need to force a release because it would only affect our ability to make a release, it shouldn't affect anyone installing from the current release. Plus, sdists for this repo are not made with setuptools, so setuptools version can't have an effect and python setup.py sdist continues to work.

@minrk minrk changed the title Omit missing directories from MANIFEST Omit missing directories from MANIFEST.in Feb 16, 2017
@minrk minrk merged commit ce77943 into ipython:master Feb 16, 2017
@neirbowj
Copy link
Contributor Author

@minrk: I saw this when building pandas and ipython_genutils on FreeBSD shortly after Python 3.4.6 hit the ports tree. You can follow my adventures on this thread FreeBSD python mailing list.

In summary, Python changed the implementation of distutils.filelist.findall between 3.4.5 and 3.4.6 (python/cpython@79ae967), which changed its behavior when invoked with a non-existent directory (OSError -> FileNotFoundError). setuptools restored an old gobbing feature for the graft statement in 34.0.1 (pypa/setuptools@56274b3) which avoids the underlying change because it doesn't call findall unless glob already saw the directory.

@neirbowj neirbowj deleted the clean_manifest branch February 16, 2017 20:34
@FRidh
Copy link

FRidh commented Mar 13, 2017

I just noticed this issue as well. FWIW we use setuptools 30.2.0.

@Carreau Carreau mentioned this pull request Mar 13, 2017
Carreau pushed a commit to Carreau/ipython_genutils that referenced this pull request Mar 13, 2017
Omit missing directories from MANIFEST.in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants