Parse markdown correctly when mathjax is disabled

[jhamrick]

This should resolve #3835

[Carreau]

Hum, I suppose you discovered that in the plane :-) for the flight back you can install mathjax locally before taking off :-) will test with no internet connexion to see if it also works.

[jhamrick]

Yeah, I just installed mathjax locally -- I will investigate further when I lose internet :-)

[Carreau]

I htink this is more a question of remove_math that return a string

 if (!window.MathJax) {
            return text;
}

Instead of a tuple of 2 elements [text,math] (with math=null) when Mathjax is not loaded :-)

[jhamrick]

Ahh, yeah, that makes more sense. I will update the pull request in a few hours when I can push from my laptop again.

[Carreau]

Good second flight. And work also on your PhD. :-)

You might want to merge #3838 and set custom mathjax_url to simulate a fail to load mathjax now that you have local version :-)

[minrk]

no var on text or math here, they are both declared above.

(I know this isn't a change you introduced, but might as well fix it while we are here).

[jhamrick]

Alright, I updated the PR. I checked to see what happens when even with mathjax installed locally. Without the PR:

1. With internet -- cells render correcty
2. With local mathjax, without internet -- cells render correctly
3. Without local mathjax, without internet -- cells render incorrectly
4. With --no-mathjax -- cells render incorrectly

This should fix both cases 3 and 4. I went ahead and also fixed the code (which is basically identical) for heading cells, which suffer from the same bug.

[jhamrick]

Also @Carreau I'm not totally sure what you mean by setting the custom mathjax_url to simulate a failure to load. But, I see #3838 was closed -- so is that suggestion still relevant?

[minrk]

tested locally while off-network, and seems to work fine. 👍 to merge.

[Carreau]

Le mardi 30 juillet 2013, Jessica B. Hamrick a écrit :

Also @Carreau https://github.com/Carreau I'm not totally sure what you
mean by setting the custom mathjax_url to simulate a failure to load.
But, I see #3838 #3838 was
closed -- so is that suggestion still relevant?

My suggestion was just to use the configurability of mathjax URL to
simulate a failure to load (set mathjax URL to Http://foo.bar which does
not exist), as when you have local mathjax installed even without Internet
it picks up the local version, except if you explicitly tell it the URL.
Any way.

Thanks for the fix, have a lot of beer, hope you're not too jet lagged. I
personally am still half way between CA and Europe.

[jhamrick]

Ahhh, I see, that makes sense. In general I tend to prefer to differentiate between the cases when there's a failure vs a feature is disabled, but it doesn't matter now anyway.

Thanks, and I will have lots of delicious german beer! :)