Remove setting of the eventloop function in the InProcessKernel#781
Merged
blink1073 merged 1 commit intoipython:masterfrom Oct 7, 2021
Merged
Remove setting of the eventloop function in the InProcessKernel#781blink1073 merged 1 commit intoipython:masterfrom
blink1073 merged 1 commit intoipython:masterfrom
Conversation
If the InProcessInteractiveShell version of `enable_gui` calls the parent function in eventloops.py, it initializes `kernel.eventloop`, whereas it should be `None` in the InProcessKernel. This triggers exceptions in the kernel's `entering_eventloop` function.
ccordoba12
approved these changes
Oct 7, 2021
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @rayosborn!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
enable_guifunction of the InProcessInteractiveShell calls a function of the same name in 'eventloops.py', which setskernel.eventloopto a function defined by the requested GUI. For the InProcessKernel,kernel.eventloopshould always be set toNone. Otherwise, commands typed in the shell trigger a call to the parent kernel class'senter_eventloopfunction, which causes an exception because attributes likeio_loopandmsg_queueare not defined by the InProcessKernel.This PR removes the call to the
enable_guifunction in 'eventloops.py' since the Qt event loop should already be running in the InProcessKernel.This is designed to fix #780 and is possibly related to #775 and #319.