Conversation
This disable most common issues that are not critical like whitespace, at least for now, so that we can fix all the issues and put flake8 in CI with an exist status. Then we can decide to renable (or not) those checks.
Carreau
added a commit
to Carreau/ipykernel
that referenced
this pull request
Jul 12, 2021
Part of the ipython#717 PR-group.
Carreau
added a commit
to Carreau/ipykernel
that referenced
this pull request
Jul 12, 2021
Some people write too much C or Typescript :-) Part of the ipython#717 PR-group.
Carreau
added a commit
to Carreau/ipykernel
that referenced
this pull request
Jul 12, 2021
Just to please flake8 Part of the ipython#717 PR-group.
Carreau
added a commit
to Carreau/ipykernel
that referenced
this pull request
Jul 12, 2021
Part of the ipython#717 PR-group. Bare excepts replaced by except Exception/BaseException
Merged
Carreau
added a commit
to Carreau/ipykernel
that referenced
this pull request
Jul 12, 2021
Unused variables are a code smell. Removing them make it clearer we expect the functions called to be called for their side-effects. Part of the ipython#717 PR-group.
Merged
Carreau
added a commit
to Carreau/ipykernel
that referenced
this pull request
Jul 12, 2021
This was forgotten as part of an earlier pass, when safe_unicode (py2 compat) was removed. safe_unicode is undefiled now and would lead to crash. Part of the ipython#717 PR-group.
blink1073
approved these changes
Jul 12, 2021
Contributor
blink1073
left a comment
blink1073
left a comment
There was a problem hiding this comment.
Fantastic, thank you for all this cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disable most common issues that are not critical like whitespace,
at least for now, so that we can fix all the issues and put flake8 in
CI with an exist status.
Then we can decide to renable (or not) those checks.