Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up release process and add tests #596

Merged
merged 1 commit into from
Feb 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Clean up release process and add tests
  • Loading branch information
afshin committed Feb 22, 2021
commit ba43397383669218a33a0df717681c9a92eae914
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ jobs:
timeout-minutes: 30
run: |
pytest ipykernel -vv -s --cov ipykernel --cov-branch --cov-report term-missing:skip-covered --durations 10
- name: Build and check the dist files
run: |
pip install build twine
python -m build .
twine check dist/*
- name: Coverage
run: |
codecov
4 changes: 2 additions & 2 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ git tag $version; true;
git push --all
git push --tags
rm -rf dist build
python setup.py sdist
python setup.py bdist_wheel
pip install build twine
python -m build .
pip install twine
twine check dist/*
twine upload dist/*
Expand Down
2 changes: 1 addition & 1 deletion ipykernel/_version.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version_info = (5, 5, 0)
version_info = (5, 6, 0, 'dev0')
__version__ = '.'.join(map(str, version_info[:3]))

# pep440 is annoying, beta/alpha/rc should _not_ have dots or pip/setuptools
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[build-system]
build-backend = "setuptools.build_meta"
requires=[
"setuptools",
"wheel",
Expand Down
7 changes: 6 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ def run(self):
raise ValueError("Version number '%s' is not valid (should match [N!]N(.N)*[{a|b|rc}N][.postN][.devN])" % current_version)


with open(pjoin(here, 'README.md')) as fid:
LONG_DESCRIPTION = fid.read()

setup_args = dict(
name=name,
version=current_version,
Expand All @@ -76,11 +79,12 @@ def run(self):
py_modules=['ipykernel_launcher'],
package_data=package_data,
description="IPython Kernel for Jupyter",
long_description_content_type="text/markdown",
author='IPython Development Team',
author_email='ipython-dev@scipy.org',
url='https://ipython.org',
license='BSD',
long_description="The IPython kernel for Jupyter",
long_description=LONG_DESCRIPTION,
platforms="Linux, Mac OS X, Windows",
keywords=['Interactive', 'Interpreter', 'Shell', 'Web'],
python_requires='>=3.5',
Expand Down Expand Up @@ -112,6 +116,7 @@ def run(self):


if any(a.startswith(('bdist', 'install')) for a in sys.argv):
sys.path.insert(0, here)
from ipykernel.kernelspec import write_kernel_spec, make_ipkernel_cmd, KERNEL_NAME

# When building a wheel, the executable specified in the kernelspec is simply 'python'.
Expand Down