Avoid ResourceWarning on implicitly closed event pipe sockets #1125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes spyder-ide/spyder#21017
since there's no 'on thread close event', we need to garbage collect event pipes periodically. I don't love this, and the old code was a lot simpler and closed things always and only when needed, but it's not a great pattern to rely on
__del__
to close things, which is why it raises a ResourceWarning.There will only be something to do when a thread has:
so run quite rarely (e.g. 10 seconds)
To see the issue, run: