Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: there can be only one comm_manager #1049

Merged
merged 7 commits into from
Dec 7, 2022
Merged

Fix: there can be only one comm_manager #1049

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f42999
fix: there can be only one comm_manager
maartenbreddels Dec 7, 2022
25b2551
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 7, 2022
fee98e5
fix init and add tests
blink1073 Dec 7, 2022
f882115
make variables private
blink1073 Dec 7, 2022
08f75b5
bump min comm version
blink1073 Dec 7, 2022
7f49118
bump min traitlets version
blink1073 Dec 7, 2022
624972e
fix traitlets dep range again
blink1073 Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Dec 7, 2022
commit 25b255103a243f0b704bb7c2c2bb8e9033d49224
1 change: 0 additions & 1 deletion ipykernel/tests/test_comm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from ipykernel.comm import Comm
from ipykernel.ipkernel import IPythonKernel

from .utils import kernel


async def test_comm(kernel):
Expand Down