Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurables needs to be configurable #1037

Merged
merged 9 commits into from
Nov 29, 2022
Merged

Configurables needs to be configurable #1037

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fcf565f
Configurables needs to be configurable.
Carreau Nov 28, 2022
17f3c83
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 28, 2022
ff69932
override create_manager
blink1073 Nov 29, 2022
b55eede
add import
blink1073 Nov 29, 2022
cd39dc5
fix import
blink1073 Nov 29, 2022
ae2dedd
fix imports
blink1073 Nov 29, 2022
c6482fe
Merge branch 'main' into configurables-aught-to-be-configurables
blink1073 Nov 29, 2022
4606a77
fix test
blink1073 Nov 29, 2022
c53280c
fix override name
blink1073 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
override create_manager
  • Loading branch information
@blink1073
blink1073 authored Nov 29, 2022
commit ff69932accd71820fca8ac3c739634ca216b76b9
10 changes: 8 additions & 2 deletions ipykernel/ipkernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,18 @@
_EXPERIMENTAL_KEY_NAME = "_jupyter_types_experimental"


def create_comm(*args, **kwargs):
def _create_comm(*args, **kwargs):
"""Create a new Comm."""
return BaseComm(*args, **kwargs)


comm.create_comm = create_comm
def _create_manager(*args, **kwargs):
"""Create a new CommManager."""
return CommManager(*args, **kwargs)


comm.create_comm = _create_comm
comm.create_manager = _create_manager


class IPythonKernel(KernelBase):
Expand Down