This repository was archived by the owner on Sep 12, 2022. It is now read-only.
Addsearchprog #46
Open
Addsearchprog #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll spend some time looking into you pull requests. |
ipod825
suggested changes
Dec 8, 2021
|
|
||
|
|
||
| def Echo(msg): | ||
| vim.command(f'unsilent echo "{msg}"') | ||
| vim.command('unsilent echo "%s"' % (msg.replace("\\","\\\\"),)) |
There was a problem hiding this comment.
Please use fstring to be consistent with other part of the codebase.
pythonx/netranger/netranger.py
Outdated
| ].index(Vim.current.line) + 1 | ||
|
|
||
| self._NETRSearchStop(True) | ||
| nod=self.cur_buf.nodes[accept_line_nr-1] |
| self.NETRBufOpen() | ||
| self.NETRSearch() | ||
| else: | ||
| self.NETRParentDir() |
There was a problem hiding this comment.
I feel like this is a very niche need. Why would you want to go to parent directory when you search? Search and goto the search target sounds like a plausible need, but search and goto parent sounds like two unrelated things.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add options of and during search in order to goto dir and open search rapidly.
There is a glitch in which cursor seen twice after revisit . And also, need to press many escapes to quit search.
Still good. Also, added ignore casing the right way.
Also, forgot something in windows fix (nice to have).
Sorry, I didn't want to invest some time reorganizing commits .