feat!: remove strict length check on tuple deserialization#24
Merged
feat!: remove strict length check on tuple deserialization#24
Conversation
This should be handled by #[serde(deny_unknown_fields)] so it can also be used non-strict (for custom visitors/deserializers). Unfortunately this isn't supported upstream in serde yet, so we should work on that.
rvagg
added a commit
to rvagg/serde_ipld_dagcbor
that referenced
this pull request
Jan 30, 2025
Depends on: ipld/rust-ipld-core#24 This should be handled by #[serde(deny_unknown_fields)] so it can also be used non-strict (for custom visitors/deserializers). Unfortunately this isn't supported upstream in serde yet, so we should work on that.
Stebalien
reviewed
Feb 12, 2025
Stebalien
force-pushed
the
rvagg/nonstrict-tuple-length
branch
from
e54ea58 to
6303592
Compare
rvagg
added a commit
to rvagg/serde_ipld_dagcbor
that referenced
this pull request
Feb 13, 2025
Depends on: ipld/rust-ipld-core#24 This should be handled by #[serde(deny_unknown_fields)] so it can also be used non-strict (for custom visitors/deserializers). Unfortunately this isn't supported upstream in serde yet, so we should work on that.
Stebalien
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be handled by #[serde(deny_unknown_fields)] so it can also be used non-strict (for custom visitors/deserializers). Unfortunately this isn't supported upstream in serde yet, so we should work on that.