This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
refactor: default to CID v1 and encode with base32 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned
This was referenced Feb 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 7 7
Lines 314 314
=======================================
Hits 289 289
Misses 25 25Continue to review full report at Codecov.
|
|
Base32 encoding is a thing now, hence closing this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Any CIDs created by this module are base32 encoded by default when stringified.
Depends on: