[WIP] Implement the thing #1
Conversation
magik6k
force-pushed
the
feat/implement
branch
6 times, most recently
from
1c5d19d to
e0c8c96
Compare
magik6k
force-pushed
the
feat/implement
branch
3 times, most recently
from
05d7b30 to
8491b57
Compare
magik6k
force-pushed
the
feat/implement
branch
4 times, most recently
from
b7bfc49 to
42b886f
Compare
magik6k
force-pushed
the
feat/implement
branch
from
42b886f to
eafeffc
Compare
|
👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽 @magik6k :D Does this work in |
magik6k
force-pushed
the
feat/implement
branch
from
87879c6 to
b6b60ae
Compare
|
@diasdavid done in ipld/js-ipld#97, the tests there pass locally for me, though this needs to be reviewed/merged/released first. |
| let head = data.slice(0, headLen).toString() | ||
| let typeLen = head.match(/([^ ]+) (\d+)/) | ||
| if (!typeLen) { | ||
| setImmediate(() => callback(new Error('invalid object header'), null)) |
There was a problem hiding this comment.
You gotta say return otherwise the rest of the function will be executed.
src/resolver.js
Outdated
| ] | ||
|
|
||
| if (node.tagger) { | ||
| paths = paths.concat(personInfoPaths.map(e => 'tagger/' + e)) |
There was a problem hiding this comment.
Add the parenthesis to the arrow function: `.map((e) => 'tagger/' + e))
| 'type', | ||
| 'tag', | ||
| 'message' | ||
| ] |
There was a problem hiding this comment.
Are these constants? Move to a Constants file
There was a problem hiding this comment.
These few paths are there for every tag, I'm not really sure if it'd really be worth having a separate file for that.
| 'name', | ||
| 'email', | ||
| 'date' | ||
| ] |
There was a problem hiding this comment.
Are these constants? Move to a constant file
package.json
Outdated
| "multihashes": "^0.4.8", | ||
| "multihashing-async": "^0.4.6", | ||
| "smart-buffer": "^3.0.3", | ||
| "traverse": "^0.6.6" |
There was a problem hiding this comment.
Replace the ^ for ~ for any module that is below 1.0.0
No description provided.