Skip to content

Fixes type checking #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes type checking #8

wants to merge 1 commit into from

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Mar 30, 2021

No description provided.

@Gozala Gozala requested a review from rvagg March 30, 2021 21:56
@Gozala
Copy link
Contributor Author

Gozala commented Mar 30, 2021

I think CI fails because js-multiformats and more specifically approach ipjs uses doesn't work with git dependencies.

@rvagg
Copy link
Member

rvagg commented Mar 31, 2021

excellent! pulled this in to rvagg/multiformats-new

the git dependency doesn't work because of the build step and the need to consume dist/, I'm not sure there's a way around that for unpublished dependencies other than to set up some crazy npm script that sets it up. will fix up rvagg/multiformats-new with the new js-multiformats version when that's published and it should be green.

@rvagg rvagg closed this Mar 31, 2021
@rvagg rvagg deleted the feat/new-multiformats branch March 31, 2021 03:44
@rvagg rvagg mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg Awaiting requested review from rvagg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gozala @rvagg