basicnode: don't panic on negative index #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Sep 1, 2024
node/basicnode/list.go
Outdated
| @@ -31,6 +31,9 @@ func (plainList) LookupByNode(datamodel.Node) (datamodel.Node, error) { | |||
| return mixins.List{TypeName: "list"}.LookupByNode(nil) | |||
| } | |||
| func (n *plainList) LookupByIndex(idx int64) (datamodel.Node, error) { | |||
| if n.Length() < 0 { | |||
There was a problem hiding this comment.
do you want if the length is less than 0 here, or if idx < 0 ?
There was a problem hiding this comment.
oof of course, fixed it
MichaelMure
force-pushed
the
panic-list
branch
from
fc52373
to
9070551
Compare
willscott
approved these changes
Sep 1, 2024
rvagg
approved these changes
Sep 2, 2024
MichaelMure
added a commit
to ucan-wg/go-ucan
that referenced
this pull request
Sep 2, 2024
Waiting on ipld/go-ipld-prime#571 to be released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not too sure what error should be returned, but it's certainly better than a panic().