Port codec package tests to quicktest
#291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/qt-port-codec
branch
from
3c062db
to
e8ff2a5
Compare
masih
commented
Nov 10, 2021
warpfork
reviewed
Nov 10, 2021
mvdan
approved these changes
Nov 10, 2021
| @@ -1,14 +1,16 @@ | |||
| package dagjson | |||
| package dagjson_test | |||
masih
force-pushed
the
masih/qt-port-codec
branch
from
e8ff2a5
to
bc95373
Compare
|
Tests fail because #294 is not merged yet. Once that's merged, this branch needs a rebase and we are good to go 🚀 |
|
Said PR merged, if you want to rebase. |
masih
force-pushed
the
masih/qt-port-codec
branch
from
bc95373
to
02e33c9
Compare
|
OK now we are hitting this: |
masih
force-pushed
the
masih/qt-port-codec
branch
from
02e33c9
to
6397c8b
Compare
Implement `NodeContentEquals` quicktest checker that checks two given nodes have equal content by comparing their printout using `printer.Sprint`. This simplifies the tests that use `datamode.DeepEqual` by performing an equivalent check while producing a human-readable error when nodes are not equal. The naming for this check is inspired by a similar equality check in quicktest, named `ContentEquals`. Port the tests in `codec` package to quicktest; use: - `qt.Assert` for `wish.Require` - `qt.Check` for `wish.Wish` - `qt.IsTrue` for `ShouldEqual` over `true` - `qt.IsFalse` for `ShouldEqual` over `false` - `qt.IsNil` for `ShouldEqual` over `nil` - `NodeContentEquals` for `ShouldEqual` over nodes - `NodeContentEquals` for `datamodel.DeepEqual` over nodes Update `NodeContentEquals` for `datamodel.DeepEqual` over nodes in `node` package while at it. Port `node/mixins/TestSplitExact` over to quicktest missed out in earlier PRs. Note, to assert equality `CmpEqual` is used with an `Exporter` that exports all unexpored fields. Address TODO in node tests by using `NodeContentEquals` to check node equality. Relates to: - #219 Depends on: - #294
masih
force-pushed
the
masih/qt-port-codec
branch
from
6397c8b
to
568a6d6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
NodeContentEqualsquicktest checker that checks two givennodes have equal content by comparing their printout using
printer.Sprint. This simplifies the tests that usedatamode.DeepEqualby performing an equivalent check while producing ahuman-readable error when nodes are not equal. The naming for this check
is inspired by a similar equality check in quicktest, named
ContentEquals.Port the tests in
codecpackage to quicktest; use:qt.Assertforwish.Requireqt.Checkforwish.Wishqt.IsTrueforShouldEqualovertrueqt.IsFalseforShouldEqualoverfalseqt.IsNilforShouldEqualovernilNodeContentEqualsforShouldEqualover nodesNodeContentEqualsfordatamodel.DeepEqualover nodesUpdate
NodeContentEqualsfordatamodel.DeepEqualover nodes innodepackage while at it.Port
node/mixins/TestSplitExactover to quicktest missed out inearlier PRs. Note, to assert equality
CmpEqualis used with anExporterthat exports all unexpored fields.Address TODO in node tests by using
NodeContentEqualsto check nodeequality.
Relates to:
Depends on:
Linkand[]byteinprinter#294