selector: add tests which are driven by language-agnostic spec fixtures. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been LONG overdue. It depends on a matching PR to the specs, which is: ipld/ipld#130 . It adds the specs+docs repo as a git submodule. (This may be tetchy to some people, but they Solve Problems.) If you don't check out the submodule, these tests are just skipped. It adds github.com/warpfork/go-testmark as a new dependency. This is what parses the fixture format. It's nothing special; the fixture format is also... markdown. This parser just gives us a good combination of human readability and machine processability.
…tures. (Apparently our CI still tests go1.14 and 1.15, neither of which have... os.ReadFile, of all the banalities.)
|
Tests. Are. GREEN. 🟢 🟢 🟢 This is so badly overdue I'm merging it immediately. |
This was referenced Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been LONG overdue.
It depends on a matching PR to the specs, which is:
ipld/ipld#130 .
It adds the specs+docs repo as a git submodule.
(This may be tetchy to some people, but they Solve Problems.)
If you don't check out the submodule, these tests are just skipped.
It adds github.com/warpfork/go-testmark as a new dependency.
This is what parses the fixture format. It's nothing special;
the fixture format is also... markdown. This parser just gives us
a good combination of human readability and machine processability.