Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade from go-block-format to go-libipfs/blocks #356

Merged
merged 2 commits into from
Jan 27, 2023
Merged

feat: upgrade from go-block-format to go-libipfs/blocks #356

merged 2 commits into from
Jan 27, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jan 27, 2023

go-block-format is now deprecated: ipfs/go-block-format#37

It seems like other dependencies have to be updated in order for this to work and they will also be incorporated into go-libipfs. I will update this PR once that is the case.

@Jorropo
Copy link
Contributor

Jorropo commented Jan 27, 2023

@hacdias you just need to go get github.com/ipfs/go-block-format@latest, that required to make librairies like go-ipfs-blockstore use stubbed go-block-format.

@Jorropo Jorropo marked this pull request as ready for review January 27, 2023 13:30
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willscott
Copy link
Member

tests still seem unhappy

@Jorropo
Copy link
Contributor

Jorropo commented Jan 27, 2023

tests still seem unhappy

Yeah there is two go.mod files and there were a typo in one of the files. Fixed it.

Edit: no more things to fix :'(

@willscott
Copy link
Member

3 even, right? (v1, v2, and cmd)

@Jorropo
Copy link
Contributor

Jorropo commented Jan 27, 2023

3 even, right? (v1, v2, and cmd)

Right, cmd use an outdated version of go-car from go modules tho.

@Jorropo Jorropo merged commit 020b14c into ipld:master Jan 27, 2023
@hacdias
Copy link
Member Author

hacdias commented Jan 27, 2023

@Jorropo in a perfect world, we would also have updated https://github.com/ipfs/go-merkledag which go-car depends on, but this is also fine.

@hacdias hacdias deleted the update-go-block-format branch January 27, 2023 13:57
@Jorropo
Copy link
Contributor

Jorropo commented Jan 27, 2023

@hacdias in a perfect world go-merkledag and go-car would have been migrated to go-libipfs 🙃

Using stubs is fine, open a PR on https://github.com/ipfs/go-merkledag if you want to update it.
Also the main blocker here is go-blockstore.

@BigLep
Copy link
Contributor

BigLep commented Mar 22, 2023

For the record, per conversation in ipfs/boxo#218, it is acknowledged by PL EngRes IPFS Stewards that it was wrong a mistake to merge this PR without having maintainer approval (e.g., someone from Bedrock). Apologies to those impacted and for the trust that was tarnished. It is going to get reverted shortly by @Jorropo .

@BigLep BigLep mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants