add car root command
#283
Merged
add car root command
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
commented
Jan 13, 2022
cmd/car/testdata/script/root.txt
Outdated
| car root ${INPUTS}/sample-wrapped-v2.car | ||
| cmp stdout v2root.txt | ||
|
|
||
| stop stdin test needs car fix |
There was a problem hiding this comment.
note that the stdin variant of the command currently has issues. I want to get this command available in file mode today for users, so that work is filed as #282
There was a problem hiding this comment.
also, FYI, I usually do:
stop # explain the reason
same with skip etc
mvdan
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow listing out specified roots in a car file