Tests to verify CARv2 blockstore dosen't put duplicates and has the required de-duped blocks #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aarshkshah1992
commented
Jun 30, 2021
•
aarshkshah1992
commented
- Generates a UnixFS DAG containing duplicate blocks -> payload has been written to ensure this happens.
- Generates a CARv2 file from the UnixFS DAG using the CARv2 read-write blockstore.
- Iterates over the CARv1 payload of the CARv2 file to ensure there are no duplicates in it (this step currently fails).
- Does a CARv1 selective CAR traversal on the UnixFS DAG using an inmemory blockstore -> verified that this produces no duplicates.
- Assert that the de-duped blocks seen in the above step are the same as when we iterate the CARv1 payload of the CARv2 file.
aarshkshah1992
changed the title
mvdan
added a commit
that referenced
this pull request
Jul 1, 2021
And a test that uses duplicate hashes as well as duplicate CIDs. We reuse the same insertion index, since it's enough for this purpose. There's no need to keep a separate map or set of CIDs. While at it, make the index package not silently swallow errors, and improve the tests to handle errors more consistently. Fixes #123. Fixes #125.
|
Fixed by #127. |
mvdan
added a commit
that referenced
this pull request
Jul 16, 2021
And a test that uses duplicate hashes as well as duplicate CIDs. We reuse the same insertion index, since it's enough for this purpose. There's no need to keep a separate map or set of CIDs. While at it, make the index package not silently swallow errors, and improve the tests to handle errors more consistently. Fixes #123. Fixes #125.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.