-
Notifications
You must be signed in to change notification settings - Fork 41
Support Laravel 12 and Future Version #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Can someone please merge this PR? |
@farzanahmad For now you can add the repository from this pull request as a vcs in your composer.json "repositories": [
{
"type": "vcs",
"url": "https://github.com/matriphe/laravel-ipinfo"
}
], Then install the package with |
Thank you @matriphe @farzanahmad @3m1n3nc3 for the PR and your comments. I'm not a Laravel user so I don't know whether it's best practice to openly support future versions. Can you point me at best practices / examples for Laravel libraries and versioning? I don't have the full historical context on our library either, but I do know that we typically go though a manual test of every Laravel version before we state that we support it in our package. That may the reason why we added this version range constraint. I'll start a conversation internally and will get back to you about the next steps. |
In Laravel, the it also usually has different version for the because this library only uses honestly, we don't really need this library, because I can still use the TestingI see there is a test part in here, but I don't think it does something. it would be beneficial if we have an automated test using GitHub Actions to make sure it's compatible with the Laravel version. for testing, we can use Orchestral for this, since it doesn't need to load all the Laravel application. I can also help with setting up the GHA and the test, but the test scenario might a little bit tricky. ideally, we can have a kind of "integration test", where it makes a call to a "test server" using a special access token, that will always return consistent data, then the test will verify the result to make sure it gets all the data from IPInfo correctly by comparing it. otherwise, we only rely on a mocked data in the unit test. but this testing part is out of this discussion. |
we can also make the requirements to |
This PR removes the limitation to support future Laravel version.
This will also address issue #66.