Skip to content

fix: strip root hash from URL on error page #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2025
Merged

fix: strip root hash from URL on error page #907

merged 1 commit into from
Nov 10, 2025

Conversation

@achingbrain
Copy link
Member

@achingbrain achingbrain commented Nov 10, 2025

To not interfere with CTRL+R-style page reloads, when we there is an error to be shown, ensure we are on the bare URL and not #/.

Fixes #817 though this was also partially handled by #906 and #902

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: strip root hash from URL on error page
f5a74c2 
To not interfere with `CTRL+R`-style page reloads, when we there is
an error to be shown, ensure we are on the bare URL and not `#/`.

Fixes #817 though this was also partially handled by #906 and #902
@achingbrain achingbrain merged commit 1535f6f into main Nov 10, 2025
15 checks passed
@achingbrain achingbrain deleted the fix/strip-root-hash-from-url-on-error-page branch November 10, 2025 09:34
@web3-bot web3-bot mentioned this pull request Nov 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error handling UX inconsistency

2 participants

@achingbrain