Skip to content

fix: reloading a page with hash fragment doesnt err #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
+7 −4
Merged

fix: reloading a page with hash fragment doesnt err #860

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f59192d
fix: do not pass hash and query to vfetch
SgtPooki Sep 23, 2025
e2ec7ba
chore: jsdoc comment lint fix
SgtPooki Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/sw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,8 @@ async function fetchHandler ({ path, request, event }: FetchHandlerArg): Promise
}
/**
* abort the signal after the configured timeout.
*
* @see https://github.com/ipfs/service-worker-gateway/issues/674
*/
const signalAbortTimeout = setTimeout(() => {
abortFn({ type: 'gateway-timeout' })
Expand All @@ -572,11 +574,12 @@ async function fetchHandler ({ path, request, event }: FetchHandlerArg): Promise
event.request.signal.addEventListener('abort', abortFn)

try {
/**
* @see https://github.com/ipfs/service-worker-gateway/issues/674
*/
const url = new URL(event.request.url)
// remove the query params and hash fragment as verified-fetch/ipfs don't care about them
url.search = ''
url.hash = ''

const response = await verifiedFetch(event.request.url, {
const response = await verifiedFetch(url.href, {
signal,
headers,
redirect: 'manual',
Expand Down
Loading