fix: do no keep track of other's wantlists (#133)

CHANGELOG.md

@@ -22,6 +22,7 @@ The following emojis are used to highlight certain changes:
 ### Fixed
 
 - Rainbow no longer provides announcements of blocks via Bitswap. This is not needed to provide blocks to peers with `RAINBOW_PEERING_SHARED_CACHE`.
+- Rainbow no longer keeps track of other peer's Bitswap wantlists. It will only reply if they have the block at the moment. This should reduce the processing and memory usage.
 
 ### Security
 

go.mod

@@ -9,7 +9,7 @@ require (
 	github.com/felixge/httpsnoop v1.0.4
 	github.com/ipfs-shipyard/nopfs v0.0.12
 	github.com/ipfs-shipyard/nopfs/ipfs v0.13.2-0.20231024163508-120e0c51ee3a
-	github.com/ipfs/boxo v0.19.1-0.20240418055150-eeea41458735
+	github.com/ipfs/boxo v0.19.1-0.20240426120703-0f223aada9b8
 	github.com/ipfs/go-block-format v0.2.0
 	github.com/ipfs/go-cid v0.4.1
 	github.com/ipfs/go-datastore v0.6.0

go.sum

@@ -238,8 +238,8 @@ github.com/ipfs-shipyard/nopfs/ipfs v0.13.2-0.20231024163508-120e0c51ee3a h1:MKG
 github.com/ipfs-shipyard/nopfs/ipfs v0.13.2-0.20231024163508-120e0c51ee3a/go.mod h1:6EekK/jo+TynwSE/ZOiOJd4eEvRXoavEC3vquKtv4yI=
 github.com/ipfs/bbloom v0.0.4 h1:Gi+8EGJ2y5qiD5FbsbpX/TMNcJw8gSqr7eyjHa4Fhvs=
 github.com/ipfs/bbloom v0.0.4/go.mod h1:cS9YprKXpoZ9lT0n/Mw/a6/aFV6DTjTLYHeA+gyqMG0=
-github.com/ipfs/boxo v0.19.1-0.20240418055150-eeea41458735 h1:S6/0RWEu0f9QeI28vrEWYaHaLe3dW6F5YLBBMi19FVw=
-github.com/ipfs/boxo v0.19.1-0.20240418055150-eeea41458735/go.mod h1:hA9Ou/YnfMZOG2nQhngsbBiYt6fiJ1EhWSmccZfV+M0=
+github.com/ipfs/boxo v0.19.1-0.20240426120703-0f223aada9b8 h1:pS8x29GRkYVGC44oIlbIVB7uBKzQ8kPUVyzc4huMuDU=
+github.com/ipfs/boxo v0.19.1-0.20240426120703-0f223aada9b8/go.mod h1:hA9Ou/YnfMZOG2nQhngsbBiYt6fiJ1EhWSmccZfV+M0=
 github.com/ipfs/go-bitfield v1.1.0 h1:fh7FIo8bSwaJEh6DdTWbCeZ1eqOaOkKFI74SCnsWbGA=
 github.com/ipfs/go-bitfield v1.1.0/go.mod h1:paqf1wjq/D2BBmzfTVFlJQ9IlFOZpg422HL0HqsGWHU=
 github.com/ipfs/go-bitswap v0.11.0 h1:j1WVvhDX1yhG32NTC9xfxnqycqYIlhzEzLXG/cU1HyQ=

setup.go

@@ -15,15 +15,19 @@ import (
 	nopfs "github.com/ipfs-shipyard/nopfs"
 	nopfsipfs "github.com/ipfs-shipyard/nopfs/ipfs"
 	"github.com/ipfs/boxo/bitswap"
+	wl "github.com/ipfs/boxo/bitswap/client/wantlist"
+	bsmspb "github.com/ipfs/boxo/bitswap/message/pb"
 	bsnet "github.com/ipfs/boxo/bitswap/network"
 	bsserver "github.com/ipfs/boxo/bitswap/server"
 	"github.com/ipfs/boxo/blockservice"
 	"github.com/ipfs/boxo/blockstore"
+	"github.com/ipfs/boxo/exchange"
 	bsfetcher "github.com/ipfs/boxo/fetcher/impl/blockservice"
 	"github.com/ipfs/boxo/gateway"
 	"github.com/ipfs/boxo/namesys"
 	"github.com/ipfs/boxo/path/resolver"
 	"github.com/ipfs/boxo/peering"
+	blocks "github.com/ipfs/go-block-format"
 	"github.com/ipfs/go-cid"
 	"github.com/ipfs/go-datastore"
 	badger4 "github.com/ipfs/go-ds-badger4"
@@ -229,7 +233,7 @@ func Setup(ctx context.Context, cfg Config, key crypto.PrivKey, dnsCache *cached
 		return nil, err
 	}
 
-	bsrv := blockservice.New(blkst, bswap,
+	bsrv := blockservice.New(blkst, &noNotifyExchange{bswap},
 		// if we are doing things right, our bitswap wantlists should
 		// not have blocks that we already have (see
 		// https://github.com/ipfs/boxo/blob/e0d4b3e9b91e9904066a10278e366c9a6d9645c7/blockservice/blockservice.go#L272). Thus
@@ -431,8 +435,53 @@ func setupBitswap(ctx context.Context, cfg Config, h host.Host, cr routing.Conte
 		// ---- Server Options
 		bitswap.WithPeerBlockRequestFilter(peerBlockRequestFilter),
 		bitswap.ProvideEnabled(false),
+		// Do not keep track of other peer's wantlists, we only want to reply if we
+		// have a block. If we get it later, it's no longer relevant.
+		bitswap.WithPeerLedger(&noopPeerLedger{}),
+		// When we don't have a block, don't reply. This reduces processment.
+		bitswap.SetSendDontHaves(false),
 	)
 	bn.Start(bswap)
 
 	return bswap
 }
+
+type noopPeerLedger struct{}
+
+func (*noopPeerLedger) Wants(p peer.ID, e wl.Entry) {}
+
+func (*noopPeerLedger) CancelWant(p peer.ID, k cid.Cid) bool {
+	return false
+}
+
+func (*noopPeerLedger) CancelWantWithType(p peer.ID, k cid.Cid, typ bsmspb.Message_Wantlist_WantType) {
+}
+
+func (*noopPeerLedger) Peers(k cid.Cid) []bsserver.PeerEntry {
+	return nil
+}
+
+func (*noopPeerLedger) CollectPeerIDs() []peer.ID {
+	return nil
+}
+
+func (*noopPeerLedger) WantlistSizeForPeer(p peer.ID) int {
+	return 0
+}
+
+func (*noopPeerLedger) WantlistForPeer(p peer.ID) []wl.Entry {
+	return nil
+}
+
+func (*noopPeerLedger) ClearPeerWantlist(p peer.ID) {}
+
+func (*noopPeerLedger) PeerDisconnected(p peer.ID) {}
+
+type noNotifyExchange struct {
+	exchange.Interface
+}
+
+func (e *noNotifyExchange) NotifyNewBlocks(ctx context.Context, blocks ...blocks.Block) error {
+	// Rainbow does not notify when we get new blocks in our Blockservice.
+	return nil
+}