Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows uses hard links #69

Closed
wants to merge 1 commit into from
Closed

fix: windows uses hard links #69

wants to merge 1 commit into from

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Oct 6, 2023

there are other ways to solve this (copy, move, etc)
or using packages like lnk but I wanted to fix without
additional dependencies or change in functionality

fixes #68

@SgtPooki
Copy link
Member Author

SgtPooki commented Oct 6, 2023

testing this fix in ipfs-desktop CI via ipfs/ipfs-desktop#2658

failed on all platforms... https://github.com/ipfs/ipfs-desktop/actions/runs/6435463660/job/17476810154?pr=2658 even though it worked locally when running npm i https://github.com/ipfs/npm-kubo/tree/ff7fa83f6eb9d5910bbd10e3529ffd6be88bbdd8 in ipfs-desktop repo..

@SgtPooki
Copy link
Member Author

closing, root cause is NodeJS 18.18.0, see ipfs/ipfs-desktop#2662

@SgtPooki SgtPooki closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: npm-kubo fails to install on windows
1 participant