feat: remove writable gateway #9743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
requested changes
Mar 22, 2023
There was a problem hiding this comment.
Thanks!
before we merge, we need to add log.Fatal so users which have Gateway.Writable: true get clear, actionable error pointing at ipfs/specs#375
lidel
reviewed
Mar 24, 2023
There was a problem hiding this comment.
💭 I think sharness timeouts because I've changed the stdout for Gateway and RPC API, and something is naively grepping for old strings. If we don't circle back to this, and want to ship deprecation with Kubo 0.20 rc1, fine to undo 17b5649 for now and restore (readonly).
- (readonly) is confusing since we have Gateway.NoFetch - better to remove it from stdout - more actionable error message and docs
- removed (readonly) from gateway (less confusing that having that and Gateway.NoFetch:true at the same time) - RPC API instead of plain API
|
@lidel sharness was timing out everywhere and was fixed on #9755. I just rebased and it works fine now. |
Jorropo
reviewed
Mar 27, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely removes the writable gateway, closes #9738.
It was already deprecating and we were already pointing users at the new IPIP PR. Therefore, I decided to remove it completely and mark it as removed in the documentation.
I think that keeping the option there, as per #9738 (comment), could generate confusion, since it would be between a deprecated and removed state that would not be clear.