fix: apply API.HTTPHeaders to /webui redirect #9733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
changed the title
hacdias
changed the title
lidel
reviewed
Mar 17, 2023
| } | ||
|
|
||
| func (i *redirectHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { | ||
| for k, v := range i.headers { | ||
| w.Header()[k] = v |
There was a problem hiding this comment.
Missed this: i dod not confirm it, but iiuc this shortcut may cause bugs if user passed header name using different capitalization that used elsewhere.
@hacdias do you mind swapping this to use dedicated funcs on Header type? (like Header.Set) instead? This will make headers work no matter what notation was used by user. There is similar snippet in ./core/corehttp/gateway_writable.go that also needs to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9728.