Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add refs local alias repo ls #9320

Merged
merged 2 commits into from
Oct 13, 2022
Merged

add refs local alias repo ls #9320

merged 2 commits into from
Oct 13, 2022

Conversation

susarlanikhilesh
Copy link
Contributor

Added sub command "ls" under "repo" command and gave RefsLocalCmd.

This helps to maintain both the commands for backward compatibility and easy modification which reflects in "repo ls".

@welcome
Copy link

welcome bot commented Oct 1, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@BigLep BigLep added the need/maintainer-input Needs input from the current maintainer(s) label Oct 3, 2022
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for your PR, it is fixing the thing.

However the test allow list isn't happy:

=== Failed
=== FAIL: core/commands TestCommands (0.00s)
    commands_test.go:276: "/repo/ls" in result but shouldn't be

Could you please take a look at the CI and fix it ? 🙂

@Jorropo Jorropo removed the need/maintainer-input Needs input from the current maintainer(s) label Oct 13, 2022
@susarlanikhilesh
Copy link
Contributor Author

LGTM, thx for your PR, it is fixing the thing.

However the test allow list isn't happy:

=== Failed
=== FAIL: core/commands TestCommands (0.00s)
    commands_test.go:276: "/repo/ls" in result but shouldn't be

Could you please take a look at the CI and fix it ? 🙂

Sure will take a look.

@susarlanikhilesh
Copy link
Contributor Author

LGTM, thx for your PR, it is fixing the thing.

However the test allow list isn't happy:

=== Failed
=== FAIL: core/commands TestCommands (0.00s)
    commands_test.go:276: "/repo/ls" in result but shouldn't be

Could you please take a look at the CI and fix it ? 🙂

Fixed the CI too

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@Jorropo Jorropo merged commit 553d3e0 into ipfs:master Oct 13, 2022
@susarlanikhilesh susarlanikhilesh deleted the fix/alias-refs-local branch October 13, 2022 15:31
@susarlanikhilesh susarlanikhilesh restored the fix/alias-refs-local branch October 13, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants